Skip to content
This repository was archived by the owner on Sep 29, 2025. It is now read-only.

fix: use fork of oapi-codegen with fixes #49

Merged
dbarrosop merged 1 commit into from
Aug 1, 2025
Merged

fix: use fork of oapi-codegen with fixes #49

dbarrosop merged 1 commit into from
Aug 1, 2025

Conversation

@dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Aug 1, 2025 •
edited by github-actions bot
Loading

PR Type

Bug fix

Description

  • Switch to fork of oapi-codegen with fixes

  • Update version from 2.5.0 to 2.6.0-beta0

  • Change repository owner from oapi-codegen to dbarrosop

  • Update source hash and revision commit

Diagram Walkthrough

flowchart LR
  A["oapi-codegen v2.5.0"] -- "switch to fork" --> B["dbarrosop/oapi-codegen v2.6.0-beta0"]
  B -- "contains fixes" --> C["Updated dependency"]
Loading

File Walkthrough
Relevant files
Dependencies
go.nix
Switch to forked oapi-codegen dependency                                 

overlays/go.nix

  • Switch oapi-codegen dependency to dbarrosop fork
  • Update version from 2.5.0 to 2.6.0-beta0
  • Change repository owner and update source hash
  • Update revision to specific commit hash
 +4/-4     

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Beta Version

The PR switches to a beta version (2.6.0-beta0) of a forked dependency. This introduces potential stability risks as beta versions may contain bugs or breaking changes that could affect production systems.

 
version = "2.6.0-beta0";
Fork Dependency

The dependency is switched from the official oapi-codegen repository to a personal fork (dbarrosop). This creates a maintenance risk as the fork may not receive regular updates, security patches, or community support compared to the official repository.

 
owner = "dbarrosop";

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Clarify fork version identifier

Using a specific commit hash with a beta version string creates inconsistency and
makes it unclear what version is actually being used. Consider using a more
descriptive version identifier that reflects the fork nature, such as
"2.6.0-beta0-fork" or just the commit hash as the version.

overlays/go.nix [96-101]

-version = "2.6.0-beta0";
+version = "2.6.0-beta0-fork";
 src = final.fetchFromGitHub {
   owner = "dbarrosop";
   repo = "oapi-codegen";
   rev = "6225e75bb76ba1fa15113a7fc6aace55ad12862c";
   hash = "sha256-sXmHVIFKxnogdr9qULZ2Io7cQGG6sMMx0ZLskjz1mOc=";
 };
Suggestion importance[1-10]: 4

__

Why: The suggestion correctly identifies a minor inconsistency between using a beta version string with a specific commit hash from a fork. However, this is a relatively minor issue that doesn't affect functionality, and the proposed change is minimal.

Low

@dbarrosop dbarrosop merged commit 72243f6 into main Aug 1, 2025
3 checks passed
@dbarrosop dbarrosop deleted the oapi branch August 1, 2025 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dbm03 dbm03 dbm03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dbarrosop @dbm03